[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers
Nathan James via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu May 28 15:25:34 PDT 2020
njames93 added a comment.
It may be worth verifying that the fix-its are identical too, multiple versions of a check could be running with differing options resulting in different fix-its generated, in that case we should let clang-tidy disable any conflicting fixes for us.
Side note would it not be nicer to just group the diagnostics into one, thinking either of these ways
CHECK-MESSAGES: warning: use emplace_back instead of push_back [hicpp-use-emplace, modernize-use-emplace]
CHECK-MESSAGES: warning: use emplace_back instead of push_back [hicpp-use-emplace] [modernize-use-emplace]
This would result in cleaner diagnostics emitted and remove the need for that note.
================
Comment at: clang-tools-extra/test/clang-tidy/infrastructure/duplicate-fixes-of-alias-checkers.cpp:53
+}
\ No newline at end of file
----------------
Eugene.Zelenko wrote:
> Please add newline.
New line
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80753/new/
https://reviews.llvm.org/D80753
More information about the cfe-commits
mailing list