[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers
Eugene Zelenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu May 28 14:18:24 PDT 2020
Eugene.Zelenko added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:750
+ for (auto &Error : Errors) {
+ auto Inserted = UniqueErrors.insert(&Error);
+
----------------
Please don't use auto when type is not spelled in same statement or not iterator.
================
Comment at: clang-tools-extra/test/clang-tidy/infrastructure/duplicate-fixes-of-alias-checkers.cpp:3
+
+#include <stdio.h>
+namespace std {
----------------
cstdio. Please also separate with newline.
================
Comment at: clang-tools-extra/test/clang-tidy/infrastructure/duplicate-fixes-of-alias-checkers.cpp:53
+}
\ No newline at end of file
----------------
Please add newline.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80753/new/
https://reviews.llvm.org/D80753
More information about the cfe-commits
mailing list