[PATCH] D80723: [PowerPC] Convert vec_splats functions to macros
Colin Samples via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu May 28 10:23:42 PDT 2020
vddvss added inline comments.
================
Comment at: clang/lib/Headers/altivec.h:13670
+ )
+#elif defined(__VSX__)
+#define vec_splats(N) \
----------------
steven.zhang wrote:
> I am not sure if this is by intention. It is not semantics the same with this change. Before the change, if VSX is off, and POWER8_VECTOR && __powerpc64__ is on, vector signed/unsigned long long, signed/unsigned __int128 is not a valid candidate of vec_splats. But with this patch, they are.
No intention to change semantics. But AFICT, we throw an error if POWER8_VECTOR is on and VSX is off: https://github.com/llvm/llvm-project/blob/master/clang/lib/Basic/Targets/PPC.cpp#L222
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80723/new/
https://reviews.llvm.org/D80723
More information about the cfe-commits
mailing list