[PATCH] D80723: [PowerPC] Convert vec_splats functions to macros

Qing Shan Zhang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 28 09:15:54 PDT 2020


steven.zhang added inline comments.


================
Comment at: clang/lib/Headers/altivec.h:13670
+  )
+#elif defined(__VSX__)
+#define vec_splats(N)                                     \
----------------
I am not sure if this is by intention. It is not semantics the same with this change. Before the change, if VSX is off, and POWER8_VECTOR && __powerpc64__ is on, vector signed/unsigned long long, signed/unsigned __int128 is not a valid candidate of vec_splats. But with this patch, they are.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80723/new/

https://reviews.llvm.org/D80723





More information about the cfe-commits mailing list