[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

[Chi Chun Chen via Phabricator via cfe-commits]

cchen marked an inline comment as done.
cchen added inline comments.


================
Comment at: clang/include/clang/AST/OpenMPClause.h:5315
+      private llvm::TrailingObjects<
+          OMPMapClause, Expr *, ValueDecl *, bool, unsigned,
+          OMPClauseMappableExprCommon::MappableComponent> {
----------------
ABataev wrote:
> Why do you need this bool flag? Seems to me, it is set to `true` always if `OpenMP >= 50 && Directive == OMPD_target_update`. Could check it during the codegen rather than introduce this new extra data here?
You're right, I shouldn't add bool here since we only need it in OMPToClause and OMPFromClause. I was adding it since I'm assuming they should have the same type for the inherited TrailingObject.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79972/new/

https://reviews.llvm.org/D79972