[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added a comment.

Is my guess correct that for OpenMP >= 50 for target update directive we always emit `possibly non-continuous` runtime calls?



================
Comment at: clang/include/clang/AST/OpenMPClause.h:5315
+      private llvm::TrailingObjects<
+          OMPMapClause, Expr *, ValueDecl *, bool, unsigned,
+          OMPClauseMappableExprCommon::MappableComponent> {
----------------
Why do you need this bool flag? Seems to me, it is set to `true` always if `OpenMP >= 50 && Directive == OMPD_target_update`. Could check it during the codegen rather than introduce this new extra data here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79972/new/

https://reviews.llvm.org/D79972