[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 21 19:30:13 PDT 2020


jdoerfert added a subscriber: fghanim.
jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:244
 
-// TODO: Replace this with the real size_t type
-#define __OMP_SIZE_TYPE(NAME) OMP_TYPE(NAME, Type::getInt64Ty(Ctx))
+#define __OMP_SIZE_TYPE(NAME) OMP_TYPE(NAME, M.getDataLayout().getIntPtrType(Ctx))
 __OMP_SIZE_TYPE(SizeTy)
----------------
jhuber6 wrote:
> I'm just directly getting the SizeTy from the Module, I'm not sure if this is a permanent solution.
I actually think this is fine. Less burden on the frontends also. @fghanim looks good?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80222/new/

https://reviews.llvm.org/D80222





More information about the cfe-commits mailing list