[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

[Sam McCall via Phabricator via cfe-commits]

sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/TestTU.h:1
 //===--- TestTU.h - Scratch source files for testing -------------*- C++-*-===//
 //
----------------
This header provides a widely used abstraction and has a clear scope, please don't dump things here.


================
Comment at: clang-tools-extra/clangd/unittests/TestTU.h:94
+
+class SymbolCollectorTest : public ::testing::Test {
+public:
----------------
I don't think the API of this class has been thought through well enough to share.

Why do you need it? Can't you just use TestTU::headerSymbols() (if you need Refs and such as well, just copy its implementation - it's 2 lines long)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79862/new/

https://reviews.llvm.org/D79862