[PATCH] D79072: [Analyzer][VLASizeChecker] Check VLA size in typedef and sizeof.
Kristóf Umann via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed May 13 07:32:42 PDT 2020
Szelethus accepted this revision.
Szelethus added a comment.
This revision is now accepted and ready to land.
In D79072#2025120 <https://reviews.llvm.org/D79072#2025120>, @martong wrote:
> I'd split this patch into two as well.
>
> 1. [NFC] Refactoring parts
> 2. The actual extra additions about sizeof and typedef. WDYT?
>
> Other than that looks good.
I wouldn't change this now, but for the future, changes like splitting functions into `checkVLA` and `checkVLASize` should deserve their own revision, because the actual new logic would only take a few lines, and a few minutes to review. The biggest pain point is that both this, and the followup patch change the same code and it makes it difficult to know whats the new functionality and what is just reorganization.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79072/new/
https://reviews.llvm.org/D79072
More information about the cfe-commits
mailing list