[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

Wed May 13 14:10:05 PDT 2020

jyu2 added a comment.

In D79743#2034945 <https://reviews.llvm.org/D79743#2034945>, @zbrid wrote:

> In D79743#2034792 <https://reviews.llvm.org/D79743#2034792>, @jyu2 wrote:
>
> > Two questions:
> >  1>	What happen under SLH, will asm goto gets removed, or a runtime problem?
> >  2>	Should we emit error or warning in the Parser instead?
>
>
>
>
> 1. SLH crashes with an unhelpful error message.
> 2. I'd be happy to emit the warning in the Parser. Could you give me a pointer to where in the parser would be appropriate? I'm not super familiar with the clang codebase. Also why do you think the parser would be a better place? (Asking to learn since I'm new to this area)

Understand, no problem!
Do you mean runtime crash? If so, I think error should be emit, so that programmer can remove use of "asm goto" and recompile.

It to me,  you can emit error somewhere in ParseAsmStatement when “goto” is parsed.  Let me know if you have problem.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79743/new/

https://reviews.llvm.org/D79743