[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

[Zola Bridges via Phabricator via cfe-commits]

zbrid added a comment.

In D79743#2034792 <https://reviews.llvm.org/D79743#2034792>, @jyu2 wrote:

> Two questions:
>  1>	What happen under SLH, will asm goto gets removed, or a runtime problem?
>  2>	Should we emit error or warning in the Parser instead?




1. SLH crashes with an unhelpful error message.
2. I'd be happy to emit the warning in the Parser. Could you give me a pointer to where in the parser would be appropriate? I'm not super familiar with the clang codebase. Also why do you think the parser would be a better place? (Asking to learn since I'm new to this area)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79743/new/

https://reviews.llvm.org/D79743