[PATCH] D79121: Add nomerge function attribute to clang

[Zequan Wu via Phabricator via cfe-commits]

zequanwu marked an inline comment as done.
zequanwu added inline comments.


================
Comment at: clang/lib/Sema/SemaStmtAttr.cpp:178
+    return true;
+  return llvm::any_of(S->children(), hasCallExpr);
+}
----------------
rsmith wrote:
> This will recurse into too much (eg, the bodies of lambdas and blocks, and unevaluated operands). It would be better to make this a `ConstEvaluatedExprVisitor` instead (see include/clang/AST/EvaluatedExprVisitor.h).
Do you mean to create a subclass of `ConstEvaluatedExprVisitor` to find if the statement has call expression?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79121/new/

https://reviews.llvm.org/D79121