[PATCH] D79121: Add nomerge function attribute to clang

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 4 18:18:47 PDT 2020


rsmith added inline comments.


================
Comment at: clang/lib/Sema/SemaStmtAttr.cpp:178
+    return true;
+  return llvm::any_of(S->children(), hasCallExpr);
+}
----------------
This will recurse into too much (eg, the bodies of lambdas and blocks, and unevaluated operands). It would be better to make this a `ConstEvaluatedExprVisitor` instead (see include/clang/AST/EvaluatedExprVisitor.h).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79121/new/

https://reviews.llvm.org/D79121





More information about the cfe-commits mailing list