[PATCH] D79302: [clangd] Propogate context in LSPServer tests

[Sam McCall via cfe-commits]

On Sun, May 3, 2020, 3:22 PM Kadir Cetinkaya via Phabricator <
reviews at reviews.llvm.org> wrote:

> kadircet marked 3 inline comments as done.
> kadircet added inline comments.
>
>
> ================
> Comment at: clang-tools-extra/clangd/unittests/LSPClient.cpp:120
> +      auto Req = std::move(Requests.front());
> +      // Leave request on the queue so that waiters can see it.
>        Lock.unlock();
> ----------------
> sammccall wrote:
> > which waiters? isn't it just this thread?
> i was envisioning the future(thought this already had a `blockUntilIdle`
> :D)
>
It has the "sync" method which is basically block-until-idle over LSP


>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D79302/new/
>
> https://reviews.llvm.org/D79302
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200503/23b44dc3/attachment.html>