<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, May 3, 2020, 3:22 PM Kadir Cetinkaya via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">kadircet marked 3 inline comments as done.<br>
kadircet added inline comments.<br>
<br>
<br>
================<br>
Comment at: clang-tools-extra/clangd/unittests/LSPClient.cpp:120<br>
+      auto Req = std::move(Requests.front());<br>
+      // Leave request on the queue so that waiters can see it.<br>
       Lock.unlock();<br>
----------------<br>
sammccall wrote:<br>
> which waiters? isn't it just this thread?<br>
i was envisioning the future(thought this already had a `blockUntilIdle` :D)<br></blockquote></div></div><div dir="auto">It has the "sync" method which is basically block-until-idle over LSP</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
Repository:<br>
  rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D79302/new/" rel="noreferrer noreferrer" target="_blank">https://reviews.llvm.org/D79302/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D79302" rel="noreferrer noreferrer" target="_blank">https://reviews.llvm.org/D79302</a><br>
<br>
<br>
<br>
</blockquote></div></div></div>