[PATCH] D79194: Add header guards for header files that should not be included on the PS4 platform

[Craig Topper via Phabricator via cfe-commits]

craig.topper accepted this revision.
craig.topper added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/test/Headers/x86intrin-2.c:3
+// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -ffreestanding -Wcast-qual %s -verify
+// RUN: %clang_cc1 -triple i386-unknown-unknown -fsyntax-only -ffreestanding -flax-vector-conversions=none -Wcast-qual %s -verify
+// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -ffreestanding -flax-vector-conversions=none -Wcast-qual %s -verify
----------------
dyung wrote:
> craig.topper wrote:
> > I'm not sure why we need a version with and without -flax-vector-conversions=none. "none" is the strictest setting I think. So if we pass with that why do we need to check without it?
> I'm not sure, I didn't add that test, I only took the existing RUN lines and duplicated each to run with an i386/x86-64 generic triple.
Looks like its been like that since the commit that added it. Let's leave it alone.


================
Comment at: clang/test/Headers/x86intrin-2.c:7
+// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -ffreestanding -Wcast-qual -x c++ %s -verify
+// REQUIRES: x86-registered-target
 // expected-no-diagnostics
----------------
We don't need the x86-registered-target if we're not running IR passes do we?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79194/new/

https://reviews.llvm.org/D79194