[PATCH] D79194: Add header guards for header files that should not be included on the PS4 platform

Douglas Yung via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 30 15:06:36 PDT 2020


dyung added inline comments.


================
Comment at: clang/test/Headers/x86intrin-2.c:3
+// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -ffreestanding -Wcast-qual %s -verify
+// RUN: %clang_cc1 -triple i386-unknown-unknown -fsyntax-only -ffreestanding -flax-vector-conversions=none -Wcast-qual %s -verify
+// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -ffreestanding -flax-vector-conversions=none -Wcast-qual %s -verify
----------------
craig.topper wrote:
> I'm not sure why we need a version with and without -flax-vector-conversions=none. "none" is the strictest setting I think. So if we pass with that why do we need to check without it?
I'm not sure, I didn't add that test, I only took the existing RUN lines and duplicated each to run with an i386/x86-64 generic triple.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79194/new/

https://reviews.llvm.org/D79194





More information about the cfe-commits mailing list