[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)

[David Blaikie via Phabricator via cfe-commits]

dblaikie added a comment.

Yeah, I was confused by all this too - @aganea's right - this review doesn't make sense to me, since it doesn't show a proposed change to LLVM, it shows a proposed change on top of another patch, that would necessarily be committed together/in a single commit (a proposed change on top of another change that's part of a series of independently valid changes are quite different - such a patch series is generally encouraged to ensure small/isolated changes). Things that are going to be committed in a single commit should be reviewed as such.

Reopening the previous review, or starting a new one (including this one - but updating it to include all the changes you're proposing to commit together/a diff relative to the current upstream trunk/tip-of-tree) & linking to the old one for context, sounds suitable.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74846/new/

https://reviews.llvm.org/D74846