[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)
Alexandre Ganea via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 28 08:02:03 PDT 2020
aganea added a comment.
To ease reviewers comprehension you have to propose patches that diff against the master. People sometimes apply the patches locally before accepting them.
This current patch is a subtraction after D69778 <https://reviews.llvm.org/D69778> is applied locally on master. It seems a bit complicated.
I think it is better if you closed this, and applied all the changes you mean to do on D69778 <https://reviews.llvm.org/D69778> and re-open. I think it is a good patch, it was already accepted, you only need to demonstrate that the edge cases where it was failing are solved.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74846/new/
https://reviews.llvm.org/D74846
More information about the cfe-commits
mailing list