[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

[Denis Petrov via cfe-commits]

Welcome to my another idea to improve RangeConstraintManager? https://reviews.llvm.org/D78933


________________________________
Denys Petrov
Senior С++ Developer | Kharkiv, Ukraine

________________________________
От: Balazs Benics via Phabricator <reviews at reviews.llvm.org>
Отправлено: 10 апреля 2020 г. 15:53
Кому: benicsbalazs at gmail.com; noqnoqneo at gmail.com; adam.balogh at ericsson.com; dabis.csaba98 at gmail.com; dkszelethus at gmail.com
Копия: richard.szalay at ericsson.com; xazax.hun at gmail.com; peterszecsi95 at gmail.com; rekanikolett at gmail.com; a.sidorin at samsung.com; mikhail.ramalho at gmail.com; donat.nagy at ericsson.com; daniel.krupp at ericsson.com; martongabesz at gmail.com; Denis Petrov; cfe-commits at lists.llvm.org; mlekena at skidmore.edu; blitzrakete at gmail.com; shenhan at google.com; 1.int32 at gmail.com
Тема: [PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.  If you suspect potential phishing or spam email, report it to ReportSpam at accesssoftek.com

steakhal updated this revision to Diff 256551.
steakhal added a comment.

- rewritten the `RangeSet::compare` function and checked the assumptions on WolframAlpha
- moved the `RangeSet::compare` function to a cpp file
- added comments to the `RangeSet::compare` function
- fixed the comment in `RangeConstraintManager::canReasonAbout` function
- introduced the `RangeSet::CompareResult::identical` enum value to be complete
- updated the `RangeConstraintManager::tryAssumeSymSymOp` accoding the `identical` CompareResult.
- omited testing the `[2,5] < [5,10]` testcase, since that is covered by `[0,5] < [5,10]`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77792/new/

https://reviews.llvm.org/D77792

Files:
  clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h
  clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
  clang/lib/StaticAnalyzer/Core/RangedConstraintManager.cpp
  clang/test/Analysis/constraint-manager-sym-sym.c

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200428/410276b3/attachment.html>