<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=koi8-r">
<style type="text/css" style="display:none"><!-- p { margin-top: 0px; margin-bottom: 0px; } .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: 2px solid rgb(128, 0, 0); }--></style>
</head>
<body dir="ltr" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;">
<p>Welcome to my another idea to improve RangeConstraintManager <a href="https://reviews.llvm.org/D78933">https://reviews.llvm.org/D78933</a><br>
</p>
<p><br>
</p>
<div id="Signature">
<div name="divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<hr>
<div><b>Denys Petrov</b></div>
<div>Senior С++ Developer | Kharkiv, Ukraine</div>
<div><br>
</div>
<div></div>
</div>
</div>
<div style="color: rgb(33, 33, 33);">
<div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>От:</b> Balázs Benics via Phabricator <reviews@reviews.llvm.org><br>
<b>Отправлено:</b> 10 апреля 2020 г. 15:53<br>
<b>Кому:</b> benicsbalazs@gmail.com; noqnoqneo@gmail.com; adam.balogh@ericsson.com; dabis.csaba98@gmail.com; dkszelethus@gmail.com<br>
<b>Копия:</b> richard.szalay@ericsson.com; xazax.hun@gmail.com; peterszecsi95@gmail.com; rekanikolett@gmail.com; a.sidorin@samsung.com; mikhail.ramalho@gmail.com; donat.nagy@ericsson.com; daniel.krupp@ericsson.com; martongabesz@gmail.com; Denis Petrov; cfe-commits@lists.llvm.org;
mlekena@skidmore.edu; blitzrakete@gmail.com; shenhan@google.com; 1.int32@gmail.com<br>
<b>Тема:</b> [PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. If you suspect potential phishing or spam email, report it to ReportSpam@accesssoftek.com<br>
<br>
steakhal updated this revision to Diff 256551.<br>
steakhal added a comment.<br>
<br>
- rewritten the `RangeSet::compare` function and checked the assumptions on WolframAlpha<br>
- moved the `RangeSet::compare` function to a cpp file<br>
- added comments to the `RangeSet::compare` function<br>
- fixed the comment in `RangeConstraintManager::canReasonAbout` function<br>
- introduced the `RangeSet::CompareResult::identical` enum value to be complete<br>
- updated the `RangeConstraintManager::tryAssumeSymSymOp` accoding the `identical` CompareResult.<br>
- omited testing the `[2,5] < [5,10]` testcase, since that is covered by `[0,5] < [5,10]`<br>
<br>
<br>
CHANGES SINCE LAST ACTION<br>
<a href="https://reviews.llvm.org/D77792/new/">https://reviews.llvm.org/D77792/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D77792">https://reviews.llvm.org/D77792</a><br>
<br>
Files:<br>
clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h<br>
clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp<br>
clang/lib/StaticAnalyzer/Core/RangedConstraintManager.cpp<br>
clang/test/Analysis/constraint-manager-sym-sym.c<br>
<br>
</div>
</span></font></div>
</body>
</html>