[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang/lib/Analysis/CFG.cpp:2855
+         VA = FindVA(VA->getElementType().getTypePtr())) {
+      if (CFGBlock *newBlock = addStmt(VA->getSizeExpr()))
+        LastBlock = newBlock;
----------------
balazske wrote:
> aaron.ballman wrote:
> > newBlock -> NewBlock per coding standard.
> Another thing is to follow the style of the source code. In the same function `newBlock` is used at other places, it would look even worse (or not?) to change just that single new occurrence to `NewBlock`.
I don't insist on the change, but when the local code is already inconsistent with its naming conventions like this is, I think new code should follow the coding standard unless there's a strong reason to deviate. This way, over time, the file converges more and more on following the coding standard instead of getting more and more inconsistent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77809/new/

https://reviews.llvm.org/D77809