[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

Balázs Kéri via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 24 02:40:51 PDT 2020


balazske added inline comments.


================
Comment at: clang/lib/Analysis/CFG.cpp:2855
+         VA = FindVA(VA->getElementType().getTypePtr())) {
+      if (CFGBlock *newBlock = addStmt(VA->getSizeExpr()))
+        LastBlock = newBlock;
----------------
aaron.ballman wrote:
> newBlock -> NewBlock per coding standard.
Another thing is to follow the style of the source code. In the same function `newBlock` is used at other places, it would look even worse (or not?) to change just that single new occurrence to `NewBlock`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77809/new/

https://reviews.llvm.org/D77809





More information about the cfe-commits mailing list