[PATCH] D75068: libclang: Add static build support for Windows

[Cristian Adam via Phabricator via cfe-commits]

cristian.adam marked an inline comment as done.
cristian.adam added a comment.

Since I do not have commit rights, I require help to get this merged.



================
Comment at: clang/tools/libclang/CMakeLists.txt:88
 
+if (WIN32 AND ENABLE_SHARED AND ENABLE_STATIC)
+  unset(ENABLE_STATIC)
----------------
rnk wrote:
> Essentially, this is the fix: don't try to build both libclang.lib for static linking and libclang.dll (and implicitly libclang.lib) on Windows. Is that accurate?
Correct. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75068/new/

https://reviews.llvm.org/D75068