[PATCH] D75068: libclang: Add static build support for Windows

Thu Apr 23 11:21:44 PDT 2020

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm, assuming my understanding is correct.

================
Comment at: clang/tools/libclang/CMakeLists.txt:88

+if (WIN32 AND ENABLE_SHARED AND ENABLE_STATIC)
+  unset(ENABLE_STATIC)
----------------
Essentially, this is the fix: don't try to build both libclang.lib for static linking and libclang.dll (and implicitly libclang.lib) on Windows. Is that accurate?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75068/new/

https://reviews.llvm.org/D75068