[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

Wed Apr 22 02:08:23 PDT 2020

arichardson added a comment.

In D78478#1994923 <https://reviews.llvm.org/D78478#1994923>, @jdoerfert wrote:

> I feel there is a lot of good stuff here but it seems to mix two things. A rewrite of the script infrastructure and the UTC_ARGS stuff. If so, do you think we could split them? I feel there are also minor NFC changes that could go in on their own without review, I marked on of them below.
>
> (Partially related: Does this handle the mismatch between `enabled` configuration status and the flag names `enable/disable` or will it still add `--enabled` to the UTC_ARGS?)

It will now read the command line flag that was specified when calling parser.add_argument() and should do the right thing.

I'll split out the unrelated changes to separate reviews.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78478/new/

https://reviews.llvm.org/D78478