[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

[Johannes Doerfert via Phabricator via cfe-commits]

jdoerfert added a comment.

I feel there is a lot of good stuff here but it seems to mix two things. A rewrite of the script infrastructure and the UTC_ARGS stuff. If so, do you think we could split them? I feel there are also minor NFC changes that could go in on their own without review, I marked on of them below.

(Partially related: Does this handle the mismatch between `enabled` configuration status and the flag names `enable/disable` or will it still add `--enabled` to the UTC_ARGS?)



================
Comment at: llvm/utils/update_cc_test_checks.py:109
                       help='"clang" executable, defaults to $llvm_bin/clang')
-  parser.add_argument('--clang-args',
+  parser.add_argument('--clang-args', default=[], type=str_to_commandline,
                       help='Space-separated extra args to clang, e.g. --clang-args=-v')
----------------
I guess these 7 lines can be committed on their own as NFC cleanup.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78478/new/

https://reviews.llvm.org/D78478