[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

Sat Apr 11 07:59:17 PDT 2020

ASDenysPetrov added a comment.

@thakis,

> ^ This is not usually true. (But I think lit adds build/bin to the PATH for tests, so it's possibly true for tests, which would be enough.)

AFAIK lit do not add anything to PATH. You should do it by yourself.

> If you run `del bin\*` followed by `make check-clang` (or `ninja check-clang` or what have you), then I think bin/scan-build won't be built since it's not a dependency of the check-clang target. It doesn't have to be a dependency on non-Win, but on Win the execution flow is different due to the bat trampoline.

I did as you ask. Confirm your suggestion: scan-build have not appeared after `ninja check-clang`. All the tests except one passed. Log attached F11713079: log_ninja_check-clang.txt <https://reviews.llvm.org/F11713079>.
Intresting but scan-build tests haven't been run through `ninja check-clang`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76768/new/

https://reviews.llvm.org/D76768