[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

[Nico Weber via Phabricator via cfe-commits]

thakis added a comment.

In D76768#1974255 <https://reviews.llvm.org/D76768#1974255>, @ASDenysPetrov wrote:

> @thakis
>  Let me explain what works for me.
>  This is in my **PATH**:
>
> - C:\Perl\c\bin
> - C:\Perl\perl\site\bin
> - C:\Perl\perl\bin
> - D:\llvm-project\buildn\bin


^ This is not usually true. (But I think lit adds build/bin to the PATH for tests, so it's possibly true for tests, which would be enough.)

> This is what in D:\llvm-project\buildn\bin (all this is a product of ninja+gcc):
> 
> - clang.exe
> - FileCheck.exe
> - scan-build.bat
> - scan-build
> - llvm-lit.py No additional changes required (CMakeList.txt, bat editing, etc.). Than I run command promt from arbitrary dir and run next: //llvm-lit.py D:/llvm-project/clang/test/Analysis/scan-build/exclude_directories.test// Test passes. Done.

If you run `del bin\*` followed by `make check-clang` (or `ninja check-clang` or what have you), then I think bin/scan-build won't be built since it's not a dependency of the check-clang target. It doesn't have to be a dependency on non-Win, but on Win the execution flow is different due to the bat trampoline.

Please try that and confirm that you see a test failure in that scenario as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76768/new/

https://reviews.llvm.org/D76768