[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 10 06:25:45 PDT 2020


thakis added a comment.

In D76768#1974044 <https://reviews.llvm.org/D76768#1974044>, @thakis wrote:

> If I add scan-build to clang/test/CMakeLists.txt and undo my other changes, the test passes for me. I guess you always build that target, which is why you didn't see this problem. But I wonder why this isn't needed on non-Windows.


On non-Windows, %scan-build expands to clang/tools/scan-build/bin/scan-build directly, and so non-Windows doesn't require scan-build on the PATH (i.e. in bin/ in the build dir) since there's no scan-build.bat trampoline.

I wonder if %scan-build should expand to "perl clang/tools/scan-build/bin/scan-build" on Windows, instead of to scan-build.bat, so that the Windows setup is more similar to the non-Windows setup.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76768/new/

https://reviews.llvm.org/D76768





More information about the cfe-commits mailing list