[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

[Nico Weber via Phabricator via cfe-commits]

thakis added a comment.

In D76768#1971420 <https://reviews.llvm.org/D76768#1971420>, @ASDenysPetrov wrote:

> @thakis
>
> > 'perl' is not recognized as an internal or external command,
>
> I think you got another problem, that Perl isn't just presented in your PATH. It is not the case for buildbot logs.


I tried again in a `git bash` shell where perl is present. With that, I get this error: http://codepad.org/t6ZhaCXI

"Can't find scan-build on PATH."

I guess that means that the bat file runs, but the perl -s scan-build therein fails? scan-build is right next to the bat file, but the perl process can't know the directory the .bat file is in. With this change it gets a bit farther:

  -perl -S scan-build %*
  +perl -S %~dp0\scan-build %*

(Since it works for others I probably misunderstood how things are supposed to work, and this change might be wrong.)

New error:

"""

command stderr:
===============

Can't find c:\src\llvm-project\clang\tools\scan-build\bin\\scan-build on PATH, '.' not in PATH.
"""

If I also remove the `-S` switch, that goes away (what's supposed to add clang\tools\scan-build\bin to path? Or is it supposed to be copied to bin\ in the out dir? It looks like clang\tools\scan-build\CMakeList.txt has logic to copy the script around, but clang\test\CMakeLists.txt doesn't have a dependency on the scan-build target, so building `check-clang` doesn't guarantee that the script is copied. Maybe it's just this dependency that's missing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76768/new/

https://reviews.llvm.org/D76768