[PATCH] D77628: [Driver][X86] Add -mpad-max-prefix-size

Wed Apr 8 18:30:45 PDT 2020

LuoYuanke added a comment.

> This looks like it requires more thorough discussions, doesn't it? We will also need discussions with the binutils side. We requested a GCC compiler driver option long ago but we do not reach a consensus (https://gcc.gnu.org/legacy-ml/gcc/2020-01/msg00358.html). IMHO the approval was in haste. With all due respect, I think I've seen such hasty approval (without any mentioning why such decisions are justifiable) and hasty commits in this area before several times, so I'll click "Request Changes" just in case of an accidental commit.

I accept the patch, because it just expose the LLVM option in clang and nobody reply on the patch. Actually we are waiting for you and Phillip to review it. If you have concern on the option. I'm open for discussion.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77628/new/

https://reviews.llvm.org/D77628