[PATCH] D77628: [Driver][X86] Add -mpad-max-prefix-size

Wed Apr 8 10:18:57 PDT 2020

MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.

> It has similar (but slightly different) effect as GAS's option -malign-branch-prefix-size, e.g. -mpad-max-prefix-size can also elminate NOPs emitted by align directive, so we use a different name here. I remove the option -malign-branch-prefix-size since is unimplemented and not needed. If we need to be compatible with GAS, we can make -malign-branch-prefix-size an alias for this option later.

This looks like it requires more thorough discussions, doesn't it? We will also need discussions with the binutils side. We requested a GCC compiler driver option long ago but we do not reach a consensus (https://gcc.gnu.org/legacy-ml/gcc/2020-01/msg00358.html). IMHO the approval was in haste. With all due respect, I think I've seen such hasty approval (without any mentioning why such decisions are justifiable) and hasty commits in this area before several times, so I'll click "Request Changes" just in case of an accidental commit.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77628/new/

https://reviews.llvm.org/D77628