[PATCH] D77615: [Syntax] Merge overlapping top-level macros in TokenBuffer

[Sam McCall via Phabricator via cfe-commits]

sammccall marked 3 inline comments as done.
sammccall added inline comments.


================
Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:461
+
+    // If the macro invocation B starts in a macro A but ends in a file, we'll
+    // create a merged mapping for A & B by overwriting the endpoint for A's
----------------
kadircet wrote:
> maybe put As and Bs in parentheses, i.e:
> ```
> // If the macro invocation (B) starts in a macro (A) but ends in a file, we'll
>     // create a merged mapping (for A & B) by overwriting the endpoint for parent's (A's)
>     // startpoint.
> ```
Done, except for "parent" - the point here is there isn't really a parent/child relationship here: the arg list isn't part of the A expansion in any sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77615/new/

https://reviews.llvm.org/D77615