[PATCH] D77236: [SVE] Cleanup prior to introdution of FixedVectorType

[Eli Friedman via Phabricator via cfe-commits]

efriedma added a comment.

My thoughts, in no particular order:

1. This is orthogonal to splitting VectorType, as far as I can tell.  `Ty->getVectorNumElements()` works equally well whether the implementation asserts it's a VectorType that isn't scalable, or asserts it's a FixedVectorType.
2. This needs to be split up; it's way too long to read, and it's mixing functional and non-functional changes.
3. It might make sense to add helpers to remove the use of cast<> in more places. For example, the inputs of a shufflevector are guaranteed to be vectors.
4. Some of the changes are leading to really crazy indentation because the `cast<>` is more characters.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77236/new/

https://reviews.llvm.org/D77236