[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

Wed Apr 1 07:52:48 PDT 2020

jasonliu added inline comments.

================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:10019
+      return SetCGInfo(
+          new PPCAIX32TargetCodeGenInfo(Types, CodeGenOpts.FloatABI == "soft"));
     return SetCGInfo(
----------------
ZarkoCA wrote:
> jasonliu wrote:
> > Does AIX have soft Float? If not, do we want to always pass in 'false'? 
> Thanks, missed changing this.  I set it to hard.
I don't think `CodeGenOpts.FloatABI == "hard"` is what we want though. Currently it means if CodeGenOpts.FloatABI is really "hard", then it will pass in `true` for `SoftFloatABI` to indicate we are soft float ABI.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76360/new/

https://reviews.llvm.org/D76360