[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

Zarko Todorovski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 30 20:46:07 PDT 2020


ZarkoCA marked 4 inline comments as done.
ZarkoCA added inline comments.


================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:10019
+      return SetCGInfo(
+          new PPCAIX32TargetCodeGenInfo(Types, CodeGenOpts.FloatABI == "soft"));
     return SetCGInfo(
----------------
jasonliu wrote:
> Does AIX have soft Float? If not, do we want to always pass in 'false'? 
Thanks, missed changing this.  I set it to hard.


================
Comment at: clang/test/CodeGen/aix-vararg.c:4
+// RUN: %clang_cc1 -triple powerpc-ibm-aix-xcoff -emit-llvm -o - %s | FileCheck %s --check-prefix=32BIT
+#include <stdarg.h>
+
----------------
jasonliu wrote:
> Any reason we don't use __builtin_va... any more?
My mistake, I somehow included the old version of the test in the diff. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76360/new/

https://reviews.llvm.org/D76360





More information about the cfe-commits mailing list