[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

Arnold Schwaighofer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 31 16:34:01 PDT 2020


aschwaighofer marked an inline comment as done.
aschwaighofer added inline comments.


================
Comment at: clang/lib/CodeGen/CGObjCRuntime.h:217
+  /// ProtocolPtrTy.
+  virtual llvm::Constant *GetOrEmitProtocol(const ObjCProtocolDecl *PD) = 0;
+
----------------
rjmccall wrote:
> Can this name more closely parallel the "external" name, like `getOrEmitProtocolObject`?
> 
> Also, I think we're incrementally lowercasing new method names.
This is an already existing method. I just moved it higher in the class hierarchy to CGObjCRuntime from CGObjCMac so that it is callable from getOrEmitProtocolObject.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77077/new/

https://reviews.llvm.org/D77077





More information about the cfe-commits mailing list