[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

[John McCall via Phabricator via cfe-commits]

rjmccall added inline comments.


================
Comment at: clang/lib/CodeGen/CGObjCGNU.cpp:623
+    llvm_unreachable("not implemented");
+  }
+
----------------
I think this is just the (unfortunately-named) `GenerateProtocolRef` (the one that just takes a protocol and not a CGF).


================
Comment at: clang/lib/CodeGen/CGObjCRuntime.h:217
+  /// ProtocolPtrTy.
+  virtual llvm::Constant *GetOrEmitProtocol(const ObjCProtocolDecl *PD) = 0;
+
----------------
Can this name more closely parallel the "external" name, like `getOrEmitProtocolObject`?

Also, I think we're incrementally lowercasing new method names.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77077/new/

https://reviews.llvm.org/D77077