[PATCH] D70265: [clang-tidy] Add CppCoreGuidelines I.2 "Avoid non-const global variables" check

Fri Mar 13 07:28:36 PDT 2020

aaron.ballman closed this revision.
aaron.ballman added a comment.

In D70265#1921013 <https://reviews.llvm.org/D70265#1921013>, @vingeldal wrote:

> In D70265#1920379 <https://reviews.llvm.org/D70265#1920379>, @aaron.ballman wrote:
>
> > LGTM! Do you need someone to commit on your behalf?
>
>
> Yes please.

Happy to do so -- I've commit on your behalf in 512767eb3fe9c34c655a480d034147c54f1d4f85 <https://reviews.llvm.org/rG512767eb3fe9c34c655a480d034147c54f1d4f85>. Thank you for the new check!

> Do I need to, or can I, do anything about the failing builds (https://reviews.llvm.org/B49012) first? They seem unrelated to my change but I'm not sure what caused that.

They're unrelated to your change, so there's nothing for you to do.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70265/new/

https://reviews.llvm.org/D70265