[PATCH] D75569: [clang-tidy] New check for methods marked __attribute__((unavailable)) that do not override a method from a superclass.

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 10 11:25:23 PDT 2020


njames93 added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/objc/MethodUnavailableNotOverrideCheck.cpp:34
+// Matches Objective-C methods that are not overriding a superclass method.
+AST_MATCHER(ObjCMethodDecl, isNotOverriding) { return !Node.isOverriding(); }
+
----------------
Not a point for this patch, but maybe this should be made into an actual matcher, though not complimented, or better yet the `CXXMethodDecl` `isOverride` matcher be extended for `ObjCMethodDecl`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75569/new/

https://reviews.llvm.org/D75569





More information about the cfe-commits mailing list