[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 12 12:28:59 PDT 2020


nridge updated this revision to Diff 250018.
nridge marked 9 inline comments as done.
nridge added a comment.
Herald added a subscriber: mgrang.

- Remove fuzzy matching
- Rebase to apply to head, taking only the parts from D75479 <https://reviews.llvm.org/D75479> that I need for index-based lookup (such as wordTouching())
- Revise tests so they exercise locateSymbolNamedTextuallyAt() directly, except for one smoke test
- Add tests that verify that we do not trigger on dependent or broken code


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72874/new/

https://reviews.llvm.org/D72874

Files:
  clang-tools-extra/clangd/FindSymbols.cpp
  clang-tools-extra/clangd/FindSymbols.h
  clang-tools-extra/clangd/XRefs.cpp
  clang-tools-extra/clangd/XRefs.h
  clang-tools-extra/clangd/unittests/XRefsTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72874.250018.patch
Type: text/x-patch
Size: 17613 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200312/f366dec5/attachment-0001.bin>


More information about the cfe-commits mailing list