[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 12 12:28:59 PDT 2020


nridge marked 2 inline comments as done.
nridge added inline comments.


================
Comment at: clang-tools-extra/clangd/XRefs.cpp:436
+    if (ScoredResults.size() >= 3) {
+      // Assume we don't have results from the current file, otherwise the
+      // findNearbyIdentifier() mechanism would have handled them.
----------------
Oh whoops, this assumption is another dependency on `findNearbyIdentifier()`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72874/new/

https://reviews.llvm.org/D72874





More information about the cfe-commits mailing list