[PATCH] D75613: [Sema] Reword -Wrange-loop-analysis warning messages

[Aaron Puchert via Phabricator via cfe-commits]

aaronpuchert updated this revision to Diff 248325.
aaronpuchert added a comment.

- Change diagnostic names to reflect the changed messages.
- Also change the wording of note_use_type_or_non_reference.
- The warning that was warn_for_range_const_reference_copy is only emitted if the operator* call returns a reference, so we should also print a reference type in the warning message. Otherwise this would be confusing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75613/new/

https://reviews.llvm.org/D75613

Files:
  clang/include/clang/Basic/DiagnosticSemaKinds.td
  clang/lib/Sema/SemaStmt.cpp
  clang/test/SemaCXX/warn-range-loop-analysis-trivially-copyable.cpp
  clang/test/SemaCXX/warn-range-loop-analysis.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75613.248325.patch
Type: text/x-patch
Size: 20623 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200304/55eb32ff/attachment-0001.bin>