[PATCH] D75613: [Sema] Reword -Wrange-loop-analysis warning messages

[Mark de Wever via Phabricator via cfe-commits]

Mordante added a comment.

Thanks for the patch! I've some minor nits, but other then that it looks fine.



================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2427
   "selected '%select{begin|end}0' %select{function|template }1%2 with iterator type %3">;
 def warn_for_range_const_reference_copy : Warning<
   "loop variable %0 "
----------------
I'd like to change this name to reflect the changed diagnostic.


================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2434
   "use non-reference type %0 to keep the copy or type %1 to prevent copying">;
 def warn_for_range_variable_always_copy : Warning<
-  "loop variable %0 is always a copy because the range of type %1 does not "
----------------
I'd like to change this name to reflect the changed diagnostic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75613/new/

https://reviews.llvm.org/D75613