[PATCH] D74907: libclang: Make shared object symbol exporting by default

Thu Feb 20 09:24:44 PST 2020

cristian.adam added a comment.

In D74907#1884795 <https://reviews.llvm.org/D74907#1884795>, @thakis wrote:

> Thanks! Does this make it so that libclang.dll is built again with -DLLVM_ENABLE_PIC=NO on Window? From what I understand, it doesn't. Is that correct? If so, could you reinstantiate that too?

It should work with `-DLLVM_ENABLE_PIC=NO` because now only the static targets get the `CINDEX_NO_EXPORTS` define.

https://reviews.llvm.org/D74564 only adds `CINDEX_EXPORTS` to `libclang` and not `obj.libclang`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74907/new/

https://reviews.llvm.org/D74907