[PATCH] D74907: libclang: Make shared object symbol exporting by default

[Cristian Adam via Phabricator via cfe-commits]

cristian.adam marked an inline comment as done.
cristian.adam added inline comments.


================
Comment at: clang/include/clang-c/Platform.h:33
   #endif
-#elif defined(CINDEX_EXPORTS)
+#elif defined(CINDEX_EXPORTS) && defined(__GNUC__)
   #define CINDEX_LINKAGE __attribute__((visibility("default")))
----------------
thakis wrote:
> Why is this change necessary?
I thought it would be nice to match the line 44, which deals with  `__attribute__((deprecated))`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74907/new/

https://reviews.llvm.org/D74907