richard.barton.arm added a comment. I'd still like to see the nits addressed and comments on the tests addressed before approving. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73951/new/ https://reviews.llvm.org/D73951