[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

David Truby via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 13 05:31:24 PST 2020


DavidTruby accepted this revision.
DavidTruby marked an inline comment as done.
DavidTruby added a comment.

LGTM but wait for someone else to approve



================
Comment at: clang/lib/Driver/Driver.cpp:131
       CCLogDiagnostics(false), CCGenDiagnostics(false),
-      TargetTriple(TargetTriple), CCCGenericGCCName(""), Saver(Alloc),
-      CheckInputsExist(true), GenReproducer(false),
+      TargetTriple(TargetTriple), CCCGenericGCCName(""), FFCGenericFortranName(""),
+      Saver(Alloc), CheckInputsExist(true), GenReproducer(false),
----------------
CarolineConcatto wrote:
> DavidTruby wrote:
> > I think you can default this to "flang" here instead of "", and then you don't need to check if it is empty later (see my later comment)
> I tried to follow the pattern set by the other tools, like GNU.
If you're following a pattern that is used in other parts of the code then this is fine by me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73951/new/

https://reviews.llvm.org/D73951





More information about the cfe-commits mailing list