[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

Alexandre Ganea via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 21 09:51:38 PST 2020


aganea added a comment.

In D72982#1831595 <https://reviews.llvm.org/D72982#1831595>, @hans wrote:

> Wait, do we really want the "(in-process)" marker to be written to a separate line? I'm not sure that we do.


Do you see value in keeping "(in-process)" at all? I added it in the first place for testing.

> The change description doesn't explain how scan-build was broken or how this fixes it.

Fixed in the summary above. Should I revert the patch and recommit with a proper description/proper fix?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72982/new/

https://reviews.llvm.org/D72982





More information about the cfe-commits mailing list